Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39902: add support for deprecating connections and connection templates #351

Merged
merged 4 commits into from
Jul 5, 2023
Merged

DM-39902: add support for deprecating connections and connection templates #351

merged 4 commits into from
Jul 5, 2023

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Jul 5, 2023 •
edited
Loading

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

TallJimbo added 3 commits July 5, 2023 15:04
@TallJimbo
Add support for deprecating connections.
320e89a
@TallJimbo
Warn about deprecated connections that are not removed.
484ee8c
@TallJimbo
Add support for deprecating connection templates.
dd9a000 
This intentionally just deprecates the corresponding config entry,
keeping those config fields from being written.  The expectation is
that deprecated templates may be used in also-deprecated connections
without emitting another warning, and then both can be removed
together.
@TallJimbo
Copy link
Member Author

This PR is just a re-branching of #349, which has already been reviewed; I'm just splitting the pipe_base off from the other packages to land it sooner and improve ticket granularity.

@TallJimbo TallJimbo mentioned this pull request Jul 5, 2023
Closed
2 tasks
@TallJimbo
Remove unused 'type: ignore' directives.
24550ee 
Quantum's attributes have flopped about a bit lately between 'list' and
'tuple' before settling on 'Sequence'.
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.44% and project coverage change: +0.02 🎉

Comparison is base (e6f13a4) 82.72% compared to head (24550ee) 82.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   82.72%   82.74%   +0.02%     
==========================================
  Files          66       66              
  Lines        7246     7281      +35     
  Branches     1408     1301     -107     
==========================================
+ Hits         5994     6025      +31     
- Misses       1005     1007       +2     
- Partials      247      249       +2
Impacted Files Coverage Δ
python/lsst/pipe/base/config.py 70.12% <ø> (ø)
python/lsst/pipe/base/graph/_implDetails.py 44.69% <ø> (ø)
python/lsst/pipe/base/graphBuilder.py 63.68% <ø> (ø)
python/lsst/pipe/base/connections.py 78.14% <85.71%> (+0.29%) ⬆️
python/lsst/pipe/base/connectionTypes.py 87.30% <100.00%> (+0.20%) ⬆️
tests/test_connections.py 99.04% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TallJimbo TallJimbo merged commit e02409d into main Jul 5, 2023
@TallJimbo TallJimbo deleted the tickets/DM-39902 branch July 5, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TallJimbo